Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job logs microservice #30

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

job logs microservice #30

wants to merge 2 commits into from

Conversation

jdonszelmann
Copy link
Member

No description provided.

NULLx76
NULLx76 reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@NULLx76 NULLx76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be personal, but I think buildstatus is a better name rather than buildlogs it isn't purely about logging but more about the status of jobs builds (something like jobstatus would be fine as well, just the "logs" seems a bit narrow)

pkg/store/jobstore.go Show resolved Hide resolved
services/buildlogs/filter.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NULLx76 NULLx76 NULLx76 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdonszelmann @NULLx76